Was requested by some users who needed these fields and which are already offered by NM.
Details
Details
- Reviewers
jgrulich - Group Reviewers
Plasma - Commits
- R116:1e001b46838e: Expose some more settings in an Advanced dialog
Changed them, then changed them back.
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13807 Build 13825: arc lint + arc unit
| libs/editor/settings/ipv4widget.cpp | ||
|---|---|---|
| 428 | What's that QPointer for? | |
| 431 | I would prefer that you used a UI file for all of this | |
| 459 | Doesn't seem to work? Or did you disable the dimming effect or is that a quirk in conjunction with QQuickWidget in systemsettings? | |
| libs/editor/settings/ipv4widget.cpp | ||
|---|---|---|
| 459 | Worked for me, I've seen issues with the list view on the left though. :/ | |
Comment Actions
Don't you miss loading/saving of those properties in loadConfig() and setting() methods?
Comment Actions
I think this UI is missing hints/tips about meaning of these options. Otherwise it would be unclear:
- What is the meaning of dad-timeout = -1
- What is the meaning of dad-timeout = 0
- What happens if dhcp-send-hostname is true, but dhcp-hostname is empty
- What happens if dhcp-send-hostname is false, but dhcp-hostname is not empty (if it would be ignored, consider disabling the line edit)
Comment Actions
You still need to add following lines to the loadConfig() method, otherwise those properties won't be filled when editing an existing connection:
m_tmpIpv4Setting.setDhcpHostname(ipv4Setting->dhcpHostname()); m_tmpIpv4Setting.setDhcpSendHostname(ipv4Setting->dhcpSendHostname()); m_tmpIpv4Setting.setDadTimeout(ipv4Setting->dadTimeout());