Without this patch happens in that case nothing. You have to leave the area
an hover again the folding begin to trigger the popup.
- Fix missing cleanup in case of unvalid mouse position
- Tried to simplify the code and improve readability
dhaumann |
KTextEditor |
Without this patch happens in that case nothing. You have to leave the area
an hover again the folding begin to trigger the popup.
TODO/QUESTIONS
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I guess the intention of the highlight delay is that when you move your mouse across the border, the view doesn't flicker. The 150ms does this well enough for me, I never see a flicker at least ;)
> Have the feeling kateview_test testDragAndDrop fails more and more often. Have already spend a lot of time in look at that but without success
Harr, with that change it looks good here. Need that a Diff here or can I commit without?
commit a8d726dbf651fde07fe2ebb1d00a055a6a0dac5d (HEAD -> fix-drag+drop-test) Author: loh tar <loh.tar@googlemail.com> Date: Sat Apr 27 11:47:08 2019 +0200 Fix kateview_test testDragAndDrop Since a while has that test not reliable worked, looks now OK here diff --git a/autotests/src/kateview_test.cpp b/autotests/src/kateview_test.cpp index cb7cb3d4..1b8d71eb 100644 --- a/autotests/src/kateview_test.cpp +++ b/autotests/src/kateview_test.cpp @@ -451,6 +451,8 @@ void KateViewTest::testDragAndDrop() QCOMPARE(view->selectionRange(), Range(1, 0, 2, 0)); QVERIFY(QTest::qWaitForWindowExposed(view)); + QTest::qWait(0); // For whatever reason needed + const QPoint startDragPos = internalView->mapFrom(view, view->cursorToCoordinate(KTextEditor::Cursor(1, 2))); const QPoint endDragPos = internalView->mapFrom(view, view->cursorToCoordinate(KTextEditor::Cursor(3, 0))); const QPoint gStartDragPos = internalView->mapToGlobal(startDragPos);
Harr, with that change it looks good here. Need that a Diff here or can I commit without?
For unit tests: if you have small improvements for the tests that make them more stable, feel free to commit that.
As long as you take afterwards a look at the CI result on build.kde.org I think that is ok.