Just added Sublime Merge icon. 3.28.2019
Details
- Reviewers
ndavis - Group Reviewers
VDG - Commits
- R266:69d7182daffc: Sublime Merge Icon.
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Thanks! The new icon looks good to me. However it looks like an xmlerrors file was accidentally added to this patch. Can you remove that?
Looks good. Since it's a proprietary program just check if they have any restrictions about having to use their icons. And yep, the xmlerrors file should be removed.
I think the cyan color is too bright and saturated. It fits the original branding well, but stands out from other Breeze icons.
I would suggest using a darker, more blue than cyan color.
I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you.
No, it's there, but for some reason I see myself as the author of the commit instead of @otavva
Oh wait no, it's not there yet, but it still looks pretty good.
However, I did notice this on a closer inspection of the shapes:
@otavva, could you make the top shape more like how it is in the official logo? You don't need to do the rounded corners, but that middle section is off.
That's how it looks when you test a patch by someone who didn't use arc to produce it: you see your own authorship info instead of theirs. Sucks, I know...
@otavva I need your email and real name to land your patch with the correct author. If you use the Arcanist tool for patches in the future, you will need to make sure that your real name is set as your Git user name.
@ndavis
Should I to put it here? Sorry for stupid question, but I don't understand you fully. And what is Arcanist tool? I'm a first time here.
Yeah just put it in a comment.
And what is Arcanist tool? I'm a first time here.
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Thanks so much @otavva! If you've found this process enjoyable and rewarding, there are plenty more icons needed! :)