Implement more tags for writing for the
taglib writer including composer, disc number,
album artist, lyricist, conductor, lyrics,
copyright and language.
Details
Details
- Reviewers
bruns mgallien ngraham - Commits
- R286:926c70460edc: Implement more tags for taglib writer
tests pass
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- enhance_taglibwriter2
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10298 Build 10316: arc lint + arc unit
Comment Actions
I forgot to add the dependent revision.
Thanks for the review, as it's been hard lately to get a reply to anything related to KFileMetaData
| autotests/taglibwritertest.cpp | ||
|---|---|---|
| 276 | You should probably add a warning when extractorList.size() > 1, as in this case the extractor you run would be arbitrary. Though, I am currently not aware of cases where one mimetype is supported by several extractors. | |
| autotests/taglibwritertest.cpp | ||
|---|---|---|
| 276 | I plan to factor this out afterwards in order to share between the different tests, I will incorporate it there. | |
| src/writers/taglibwriter.cpp | ||
|---|---|---|
| 133 | I think you have to rediff this ... | |