This patch does the groundwork for indvidual wallpaper plugins to be able to use Kirigami FormLayout with twinFormLayouts,
finally allowing us to easily ensure that both the main and child layout are aligned without hacks.
Details
Details
- Reviewers
mart ngraham - Group Reviewers
Plasma - Commits
- R119:a3d4b38574fb: Support Kirigami.twinFormLayouts in individual wallpaper plugins
Test with D19873
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Second line results in a stack not defined error.
I'm actually seeing it's enough to just have the id at line 82 and then in the wallpaper plugins do twinFormLayouts: parentLayout.
Comment Actions
remove line: twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []
Comment Actions
If there's no objections I'll land this tomorrow night so we can keep working on fixing the plugins.
I've also thought a bit more about this, and I suppose another approach would be for the master FormLayout here to also adjust itself based on the content of the wallpaper plugins, but then we would get shifting text and option positions when changing wallpaper plugins. That wouldn't look good IMO.