Support Kirigami.twinFormLayouts in individual wallpaper plugins
ClosedPublic

Authored by filipf on Mar 21 2019, 12:08 AM.

Details

Summary

This patch does the groundwork for indvidual wallpaper plugins to be able to use Kirigami FormLayout with twinFormLayouts,
finally allowing us to easily ensure that both the main and child layout are aligned without hacks.

Test Plan

Test with D19873

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Mar 21 2019, 12:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 21 2019, 12:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 21 2019, 12:08 AM
filipf edited the test plan for this revision. (Show Details)Mar 21 2019, 12:18 AM
filipf added reviewers: mart, Plasma, ngraham.

Second line results in a stack not defined error.

I'm actually seeing it's enough to just have the id at line 82 and then in the wallpaper plugins do twinFormLayouts: parentLayout.

filipf updated this revision to Diff 54485.Mar 21 2019, 1:51 PM

remove line: twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []

ngraham accepted this revision.Mon, Mar 25, 12:18 AM

Awesome.

This revision is now accepted and ready to land.Mon, Mar 25, 12:18 AM

If there's no objections I'll land this tomorrow night so we can keep working on fixing the plugins.

I've also thought a bit more about this, and I suppose another approach would be for the master FormLayout here to also adjust itself based on the content of the wallpaper plugins, but then we would get shifting text and option positions when changing wallpaper plugins. That wouldn't look good IMO.

This revision was automatically updated to reflect the committed changes.