This patch resolves the choppy OSD fadeout problem described in bug 402352 that appeared after the update to Qt 5.12.
BUG: 402352
FIXED-IN: 5.15.3
davidedmundson | |
ngraham |
Plasma | |
VDG |
This patch resolves the choppy OSD fadeout problem described in bug 402352 that appeared after the update to Qt 5.12.
BUG: 402352
FIXED-IN: 5.15.3
Before:
After:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
That removes the "slowly fade out feature of the OSD", please then also remove all uses of that property
Also, the Animation is now also entirely unused as the opacity of the window is no longer changed? Please clean this up.
There don't seem to be any other instances of it being used?
Also, the Animation is now also entirely unused as the opacity of the window is no longer changed? Please clean this up.
I don't understand, could you elaborate please?
There don't seem to be any other instances of it being used?
plasma-workspace/shell/osd.cpp
It also seems kscreen has a copy of thhis OSD which also needs fixing, and please also make sure the lockscreen doesn't break as it also embeds an OSD item.
I don't understand, could you elaborate please?
The aforementioned code checks if an animateOpacity property is present, if so, it changes the window opacity which will then be animated. If that property is gone, the code just sets the window visible which will be animated by KWin. As such, the animation in the osd.qml is entirely unused now.
plasma-workspace/shell/osd.cpp
It also seems kscreen has a copy of thhis OSD which also needs fixing, and please also make sure the lockscreen doesn't break as it also embeds an OSD item.
It won't affect the lock screen. (The lock screen was never affected by the bug either, actually)
The aforementioned code checks if an animateOpacity property is present, if so, it changes the window opacity which will then be animated. If that property is gone, the code just sets the window visible which will be animated by KWin. As such, the animation in the osd.qml is entirely unused now.
Oh God I'm so sorry I completely forgot about Kwin. I could just remove the animation entirely then?
How's that? It actually reminds me of the notification widget with these changes in place