Details
- Reviewers
timotheegiet - Group Reviewers
GCompris: Improvements
Diff Detail
- Repository
- R2 GCompris
- Branch
- leftright
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8725 Build 8743: arc lint + arc unit
In vertical and horizontal mode the score was overriding the blackboard
https://pasteboard.co/I2tbh9t.png
https://pasteboard.co/I2tbSME.png
The overriding issues were fixed
https://pasteboard.co/I2tcoJf.png
https://pasteboard.co/I2tcBVI.png
Hi,
Animtim will certainly have a better view than mine but for me it was not a problem as the blackboard is more there as background.
I find it better if when possible the score is as big as possible as GCompris is also played on very small screens like phone screens.
Hi,I have not reduced the size of the score just added some margins to fix the issue.Sure would wait for Animtim to review.
Thanks :)
Hi,
It is true that the overlapping was not really a problem. But since your change doesn't have any bad side effect I'm ok to get it merged.
Also I'll refactor the graphics and layout of this activity at some point later anyway, so this little patch is good for now.
committed in https://commits.kde.org/gcompris/e185c82d21879412ef448ab838655699fb340937 with some changes
src/activities/leftright/Leftright.qml | ||
---|---|---|
73 | hardcoding a value is never good when you have the possibility to use anchors. |