Differential D19245

leftright activity layout issues fixed
ClosedPublic
Actions

Authored by dekumar on Feb 23 2019, 9:19 AM.

Details

Reviewers
timotheegiet
Group Reviewers
GCompris: Improvements

Diff Detail

Repository
R2 GCompris
Branch
leftright
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8725
Build 8743: arc lint + arc unit
dekumar created this revision.Feb 23 2019, 9:19 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 23 2019, 9:19 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
dekumar requested review of this revision.Feb 23 2019, 9:19 AM
dekumar retitled this revision from Overriding issues fixed to leftright activity layout issues fixed.Feb 23 2019, 9:20 AM
dekumar added a reviewer: GCompris: Improvements.
dekumar added a comment.Feb 23 2019, 9:26 AM

In vertical and horizontal mode the score was overriding the blackboard
https://pasteboard.co/I2tbh9t.png
https://pasteboard.co/I2tbSME.png

The overriding issues were fixed

https://pasteboard.co/I2tcoJf.png
https://pasteboard.co/I2tcBVI.png

echarruau added a subscriber: echarruau.Feb 23 2019, 9:46 AM

Hi,
Animtim will certainly have a better view than mine but for me it was not a problem as the blackboard is more there as background.
I find it better if when possible the score is as big as possible as GCompris is also played on very small screens like phone screens.

dekumar added a comment.Feb 23 2019, 9:53 AM
In D19245#417914, @echarruau wrote:

Hi,
Animtim will certainly have a better view than mine but for me it was not a problem as the blackboard is more there as background.
I find it better if when possible the score is as big as possible as GCompris is also played on very small screens like phone screens.

Hi,I have not reduced the size of the score just added some margins to fix the issue.Sure would wait for Animtim to review.
Thanks :)

timotheegiet accepted this revision.Feb 23 2019, 11:57 AM
timotheegiet added a subscriber: timotheegiet.

Hi,
It is true that the overlapping was not really a problem. But since your change doesn't have any bad side effect I'm ok to get it merged.
Also I'll refactor the graphics and layout of this activity at some point later anyway, so this little patch is good for now.

This revision is now accepted and ready to land.Feb 23 2019, 11:57 AM
jjazeix closed this revision.Feb 24 2019, 9:38 AM
jjazeix added a subscriber: jjazeix.

committed in https://commits.kde.org/gcompris/e185c82d21879412ef448ab838655699fb340937 with some changes

src/activities/leftright/Leftright.qml
73

hardcoding a value is never good when you have the possibility to use anchors.
Here, you want to have the blackboard below the score, so let's just put the score bottom as blackboard top anchor.

Revision Contents
Changeset List

Diff 52366

View Options

src/activities/leftright/Leftright.qml

Loading...