Details
Details
- Reviewers
tcanabrava aacid mkoller - Commits
- R374:607137f17213: Remove misuse of the comma operator
Diff Detail
Diff Detail
- Repository
- R374 KolourPaint
- Branch
- comma-remove
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7260 Build 7278: arc lint + arc unit
tools/kpTool_KeyboardEvents.cpp | ||
---|---|---|
100–110 | this is harder to read. |
Comment Actions
Why are they misuses?
I mean sure, it's not what the comma operator was probably designed for, but it does work, no?
Comment Actions
except the one block it's ok
tools/kpTool_KeyboardEvents.cpp | ||
---|---|---|
127 | Please keep the "tabular" style as it was. It's more readable. |
Comment Actions
André doesn't have commit access.
@mkoller @tcanabrava will you commit it or want me to?