Remove misuse of the comma operator

Authored by andreagenor on Jan 17 2019, 12:45 PM.

Diff Detail

R374 KolourPaint
No Linters Available
No Unit Test Coverage
Build Status
Buildable 7260
Build 7278: arc lint + arc unit
andreagenor requested review of this revision.Jan 17 2019, 12:45 PM
andreagenor created this revision.
tcanabrava requested changes to this revision.Jan 17 2019, 3:24 PM
tcanabrava added inline comments.

this is harder to read.

This revision now requires changes to proceed.Jan 17 2019, 3:24 PM
  • Correct the code indentation
tcanabrava accepted this revision.Jan 17 2019, 5:00 PM
This revision is now accepted and ready to land.Jan 17 2019, 5:00 PM

Why are they misuses?

I mean sure, it's not what the comma operator was probably designed for, but it does work, no?

Yes, it works fine. Just to remove warnings.

mkoller accepted this revision.Jan 18 2019, 7:13 AM

except the one block it's ok


Please keep the "tabular" style as it was. It's more readable.

  • Adjust the indentation to tabular style
aacid added a comment.Jan 20 2019, 7:35 PM

André doesn't have commit access.

@mkoller @tcanabrava will you commit it or want me to?

André doesn't have commit access.

@mkoller @tcanabrava will you commit it or want me to?

Can you do it, please ?

aacid closed this revision.Jan 25 2019, 11:50 PM