Differential D17935

[Clipboard] Use ellipsis in the search field label ('Search...' instead of 'Search')
ClosedPublic
Actions

Authored by rooty on Jan 2 2019, 11:19 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG
Commits
R120:d066eb8cbd85: [Clipboard] Use ellipsis in the search field label ('Search...' instead of…
Summary

This patch adds the ellipsis (...) to the search field label in Clipboard so as to make it consistent with the labels in Kickoff, Kicker and KRunner.

Test Plan

Before:


After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
clipboard-search-ellipsis (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6593
Build 6611: arc lint + arc unit
rooty created this revision.Jan 2 2019, 11:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 2 2019, 11:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Jan 2 2019, 11:19 PM
rooty edited the test plan for this revision. (Show Details)Jan 2 2019, 11:19 PM
rooty added reviewers: ngraham, Plasma, VDG.
filipf added a subscriber: filipf.Jan 3 2019, 12:02 AM

I'd suggest to do align all the wrong labels in this repo with the HiG so as to avoid too many diffs.

ngraham accepted this revision.Jan 3 2019, 4:08 AM
This revision is now accepted and ready to land.Jan 3 2019, 4:08 AM
Closed by commit R120:d066eb8cbd85: [Clipboard] Use ellipsis in the search field label ('Search...' instead of… (authored by Krešimir Čohar <kcohar@gmail.com>, committed by GB_2). · Explain WhyJan 3 2019, 6:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48581

View Options

applets/clipboard/contents/ui/ClipboardPage.qml

Loading...