I tested a bit of code with -02 to measure the speed gains of using a std::initializer_list over appending to a temporary and appending to temporary is around 50% slower, so I removed all the code that appened to temporaries for a initializer list in breeze.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Breeze Plasma - Commits
- R31:c671ea190645: Set complete vectors instead of creting them at runtime
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This comment was removed by zzag.
kstyle/breezeshadowhelper.cpp | ||
---|---|---|
511–515 | they where added to the data vector before, and the data vector is quint32, so I don't see the difference. |
kdecoration/breezesizegrip.cpp | ||
---|---|---|
147–148 | Also, couldn't you do painter.drawPolygon( QVector<>{} ); |
Comment Actions
- Don't realloc _pixmap vector
- Don't use a Temporary to Copy data over
- Fix compile
- Don't use temporaries, compilers can optimize better this way
Comment Actions
Sadly Breeze lost its maintainer recently, so reviewing this is going to have to be a community effort. Adding more people.