Fixed detection of horizontal progressbar by re-introducing check on…

Authored by hpereiradacosta on Jun 17 2018, 10:28 AM.

Description

Fixed detection of horizontal progressbar by re-introducing check on QStyleOptionProgressBar::orientation. Using option->state only even for Qt5 breaks ktorrent.

CCMAIL: vladzzag@gmail.com

Details

Committed
hpereiradacostaJun 17 2018, 10:28 AM
Parents
R31:4535408ea7f4: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown
zzag added a subscriber: zzag.Jun 17 2018, 10:54 AM

Does KTorrent use its own "progress bar"?

Probably ktorrent uses some custom code yes (did not check). So probably used some deprecated code. Still: deprecated we must support: this is valid Qt code, we cannot break applications that use it. Makes sense ?

And yes, it is not broken when using fusion style.
So lets check both settings. In general lets try not fix something that is not broken (meaning: unless there is a bug report about it, or something spotted broken explicitly)

zzag added a comment.Jun 17 2018, 11:23 AM

Probably ktorrent uses some custom code yes (did not check). So probably used some deprecated code. Still: deprecated we must support: this is valid Qt code, we cannot break applications that use it. Makes sense ?

And yes, it is not broken when using fusion style.
So lets check both settings. In general lets try not fix something that is not broken (meaning: unless there is a bug report about it, or something spotted broken explicitly)

Yes, that seems to be very sensible. I think we should keep eye on orientation because it's obsolete http://doc.qt.io/qt-5.11/qstyleoptionprogressbar-obsolete.html
But, yeah, I totally agree with you.