Right now there is an icon associated with each rotation, but they
do not actually make much sense since they are not rotation arrows, but just
arrows pointing to the sides/up/down.
Instead use the view-preview icon and rotate it.
Details
- Reviewers
ngraham romangg - Group Reviewers
Plasma VDG - Commits
- R104:200cdd782e5f: Change rotation icons to be a rotated preview icon
Diff Detail
- Repository
- R104 KScreen
- Branch
- arcpatch-D14339
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1207 Build 1220: arc lint + arc unit
Before, with the icons:
Without:
Comments appreciated, maybe these should be buttons, but imho this is a low-hanging fruit (unless people think the icons should stay).
Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated.
With no icon at all, I think we'd regress usability because a visual hint of which way the display will be rotated is way easier to understand quickly than "90° Counterclockwise". I need to power up my brain's long-dormant geometry module to figure out what that will do.
I agree with the icons change. We might already have something like this on Breeze.
Also, would we be OK to change "Normal" for something like "Standard" or "Horizontal"?
Something like this set:
(Those are the existing view-preview icon from the Breeze theme, but rotated)
I was also thinking about "No rotation". I agree that normal is not ideal. And then the label in front says "Orientation" is that better than "Rotation"?
Note: I'm all for text changes, but they should be another independent patch.
I was also wondering if it makes sense to use a combo box in the first place - we know it's four options always, should it maybe just be four buttons/radio buttons/something else?
Looks nice!
I would approve of using radio buttons or four actual inline buttons instead of a combobox.
Also +1 on "No Rotation" instead of "Normal", and for doing that in another patch.
So will you approve this? I can make a change for the label renaming and then we can still discuss splitting it into buttons/radio/whatever :)