Change rotation icons to be a rotated preview icon
ClosedPublic

Authored by gladhorn on Jul 24 2018, 6:23 PM.

Details

Summary

Right now there is an icon associated with each rotation, but they
do not actually make much sense since they are not rotation arrows, but just
arrows pointing to the sides/up/down.
Instead use the view-preview icon and rotate it.

Diff Detail

Repository
R104 KScreen
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1137
Build 1150: arc lint + arc unit
gladhorn created this revision.Jul 24 2018, 6:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2018, 6:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 24 2018, 6:23 PM
gladhorn updated this revision to Diff 38350.Jul 24 2018, 6:24 PM

Accidentally added new ui file, thanks arc :(

Before, with the icons:

Without:

Comments appreciated, maybe these should be buttons, but imho this is a low-hanging fruit (unless people think the icons should stay).

ngraham requested changes to this revision.Jul 24 2018, 6:32 PM
ngraham added a subscriber: ngraham.

Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated.

With no icon at all, I think we'd regress usability because a visual hint of which way the display will be rotated is way easier to understand quickly than "90° Counterclockwise". I need to power up my brain's long-dormant geometry module to figure out what that will do.

This revision now requires changes to proceed.Jul 24 2018, 6:32 PM
abetts added a subscriber: abetts.Jul 24 2018, 7:09 PM

Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated.

With no icon at all, I think we'd regress usability because a visual hint of which way the display will be rotated is way easier to understand quickly than "90° Counterclockwise". I need to power up my brain's long-dormant geometry module to figure out what that will do.

I agree with the icons change. We might already have something like this on Breeze.

Also, would we be OK to change "Normal" for something like "Standard" or "Horizontal"?

Something like this set:

(Those are the existing view-preview icon from the Breeze theme, but rotated)

Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated.

With no icon at all, I think we'd regress usability because a visual hint of which way the display will be rotated is way easier to understand quickly than "90° Counterclockwise". I need to power up my brain's long-dormant geometry module to figure out what that will do.

I agree with the icons change. We might already have something like this on Breeze.

Also, would we be OK to change "Normal" for something like "Standard" or "Horizontal"?

I was also thinking about "No rotation". I agree that normal is not ideal. And then the label in front says "Orientation" is that better than "Rotation"?

gladhorn updated this revision to Diff 38382.Jul 25 2018, 7:14 AM

Use preview icon

Note: I'm all for text changes, but they should be another independent patch.
I was also wondering if it makes sense to use a combo box in the first place - we know it's four options always, should it maybe just be four buttons/radio buttons/something else?

Looks nice!

I would approve of using radio buttons or four actual inline buttons instead of a combobox.

Also +1 on "No Rotation" instead of "Normal", and for doing that in another patch.

Looks nice!

I would approve of using radio buttons or four actual inline buttons instead of a combobox.

Also +1 on "No Rotation" instead of "Normal", and for doing that in another patch.

So will you approve this? I can make a change for the label renaming and then we can still discuss splitting it into buttons/radio/whatever :)

And I see that arc just threw away my updated commit message :(, that's just weird.

gladhorn updated this revision to Diff 38486.Jul 26 2018, 9:42 AM

Updated message hopefully

gladhorn retitled this revision from Remove confusing icons from rotation combobox to Change rotation icons to be a rotated preview icon.Jul 26 2018, 9:43 AM
gladhorn edited the summary of this revision. (Show Details)
romangg accepted this revision.Jul 26 2018, 12:05 PM
ngraham accepted this revision.Jul 26 2018, 12:52 PM

Looks great, works great!

This revision is now accepted and ready to land.Jul 26 2018, 12:52 PM
This revision was automatically updated to reflect the committed changes.