I have created a new activity that allows you to trust all networks or add networks one by one to a list when you are connected to that network
Details
- Reviewers
jdvr - Group Reviewers
KDE Connect - Maniphest Tasks
- T8539: [Junior Job] Limit KDE Connect to certain (wifi) networks
- Commits
- R225:7f8f1bee30c3: T8539 - Create a new flow to manage trusted networks
Test Cases:
- By default everything should works like it works before, If you uncheck the "Allow all" option in trusted network menu and there isn't any ssid in the trusted
network list the app doesn't send the first udp package and log "Current WiFi isn't a Trusted Network"
- With the "Allow all" uncheck, use "Add: YOUR_SSID_NAME" button to add your current ssid to the trusted networks list, once you added, go back and the app should
works as always
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Branch
- T8539-limit-wifi-networks
- Lint
No Linters Available - Unit
No Unit Test Coverage
Now that we have a settings screen, this would fit there really well there.
I see the patch got messed up, though, can you rebase it and submit it again @jdvr?
This approach has a problem: Beginning with Android 8.1 we need the ACCESS_COARSE_LOCATION permission to access the Wifi SSID. It's a bit weird to ask the user for that for this feature
@jdvr Are you still interested in working on this? We would need some flow to request the permission on newer Android versions. With the runtime permissions, it seems like it would make the most sense to ask for this as soon as the user brings up the settings panel for configuring trusted networks.
Rebased onto master and added permision request. See new MR here: https://invent.kde.org/kde/kdeconnect-android/merge_requests/107