Differential D13303

Improve regex for grbl translate Add more tests for grbl translate
ClosedPublic
Actions

Authored by rizzitello on Jun 3 2018, 2:57 PM.

Details

Reviewers
patrickelectric
laysrodrigues
tcanabrava
Commits
R232:91498e6c7690: Improve regex for grbl translate Add more tests for grbl translate
R232:8cdae29652af: Improve regex for grbl translate Add more tests for grbl translate
Summary
  • Grbl::translate: Add more more comprehensive Regex that will look for more then just one option per

command

  • More tests to check Grbl::translate's unit test

Diff Detail

Repository
R232 AtCore
Branch
grbl_adjust
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Jun 3 2018, 2:57 PM
rizzitello created this revision.
tcanabrava accepted this revision.Jun 4 2018, 5:25 AM
This revision is now accepted and ready to land.Jun 4 2018, 5:25 AM
laysrodrigues accepted this revision.Jun 5 2018, 3:48 PM
rizzitello closed this revision.Jun 5 2018, 3:50 PM

Revision Contents
Changeset List

PathPackages
Msrc/plugins/grblplugin.cpp (10 lines)
Munittests/atcoretests.cpp (5 lines)

Diff 35500

View Options

src/plugins/grblplugin.cpp

Loading...
View Options

unittests/atcoretests.cpp

Loading...