Home
Phabricator
Search
Log In
Differential
D13303
Improve regex for grbl translate Add more tests for grbl translate
Closed
Public
Actions
Authored by
rizzitello
on Jun 3 2018, 2:57 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
Atelier: AtCore
Subscribers
Atelier: AtCore
Details
Reviewers
patrickelectric
laysrodrigues
tcanabrava
Commits
R232:91498e6c7690: Improve regex for grbl translate Add more tests for grbl translate
R232:8cdae29652af: Improve regex for grbl translate Add more tests for grbl translate
Summary
Grbl::translate: Add more more comprehensive Regex that will look for more then just one option per
command
More tests to check Grbl::translate's unit test
Diff Detail
Repository
R232 AtCore
Branch
grbl_adjust
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello
requested review of this revision.
Jun 3 2018, 2:57 PM
rizzitello
created this revision.
rizzitello
added reviewers:
patrickelectric
,
laysrodrigues
,
tcanabrava
.
Jun 3 2018, 3:03 PM
rizzitello
added a project:
Atelier: AtCore
.
rizzitello
added a subscriber:
Atelier: AtCore
.
rizzitello
updated this revision to
Diff 35500
.
Jun 4 2018, 2:31 AM
Comment Actions
Rebase
tcanabrava
accepted this revision.
Jun 4 2018, 5:25 AM
This revision is now accepted and ready to land.
Jun 4 2018, 5:25 AM
laysrodrigues
accepted this revision.
Jun 5 2018, 3:48 PM
rizzitello
updated this revision to
Diff 35631
.
Jun 5 2018, 3:50 PM
Comment Actions
Rebase
rizzitello
closed this revision.
Jun 5 2018, 3:50 PM