Make the handles a bit smaller and tweak the border color. This isn't breeze's proper style, but I think it fits better with the design of the player/header bar.
Also this patch makes the volume slider look disabled when muted. (see screenshot)
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:143347526272: Tweak size and color of handles for the seek/volume sliders
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Branch
- handles_tweak (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I don't like the changes to the slider to be honest. Let's wait for others to chime in.
For easier comparison, it would be nice to have before and after pictures.
The disabled volume bar is great, that annoyed me before.
Comment Actions
The disabled volume slider is much better. I am unsure about the reduction of size for the handle given that is makes it harder to touch it.
The ability to use Elisa with a touch screen is really important. That was one of the stated goals for this project.
| src/qml/MediaPlayerControl.qml | ||
|---|---|---|
| 308 | Please remove the extra blank line. | |
| 317–321 | I have a laptop with a touch screen. This kind of changes make it harder to use the sliders. Are you sure it is really worth it ? | |
| 468–471 | idem | |
Comment Actions
Heh I thought this was only affecting desktops so it didn't need to be touchable, I completely forgot PCs have touchscreens too these days.
Good points, I'll revert that later