Check if the application androiddeployqt package has a main() symbol
ClosedPublic

Authored by apol on Apr 11 2018, 6:25 PM.

Details

Summary

Back in the KDE Edu sprint, we decided we need such a check, otherwise
you get rather frustrated when the application isn't started. A patch to
androiddeployqt was submitted but rejected by the maintainer.
https://codereview.qt-project.org/#/c/207941/

Test Plan

kate doesn't build if we don't pass Q_DECL_EXPORT, builds if we do.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 11 2018, 6:25 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptApr 11 2018, 6:25 PM
apol requested review of this revision.Apr 11 2018, 6:25 PM
aacid added a subscriber: aacid.Apr 11 2018, 9:06 PM

Is this going to fail on my translated nm output?

apol added a comment.Apr 11 2018, 10:51 PM

Is this going to fail on my translated nm output?

Well it shouldn't, we're passing LANG=C which is what solved it for the other command, I don't see why nm should be any different.

vkrause accepted this revision.Apr 12 2018, 7:36 AM
vkrause added a subscriber: vkrause.

Just tested that my 64bit host nm can also consume 32bit ARM binaries, seems to work, so not using the corresponding toolchain nm is probably fine here.

This revision is now accepted and ready to land.Apr 12 2018, 7:36 AM
This revision was automatically updated to reflect the committed changes.