Details
- Reviewers
nienhueser rahn kossebau
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Hi Sanjiban,
read your mail which explains the changes to srtm.dgml. Quoting it here for @rahn "However, as for those black patches in Atlas, it turns out that the fix was pretty straightforward, and was hidden in the dgml file itself. I noticed that the "#" was missing for the brush color values for ne_50m_lakes and ne_50m_glaciated_areas in strm.dgml. After adding those, things are working fine, Greenland is not rendering black anymore and the lakes in North America (and elsewhere) have also started rendering blue, which was not the case earlier. There still remained some black patches around the Antarctica, and a couple of lakes in Africa and Kazakhstan, but I exchanged the brush and pen colors for ne_50m_antarctic_ice_shelves_polys, and ne_50m_lakes_historic respectively, and those got fixed as well.
Great catch! We should backport that part to older releases as well. Therefore it would be great if we could have separate commits for the brush/pen changes in srtml.dgml and the renderOrder feature implementation. I'd also like @rahn to have a look at srtm.dgml, especially the glacier areas in there. I wonder if it is possible to have the elevation model shine through (i.e. colorize ice instead of overpaint white)?
Although this patch solves the target problem only partially, this patch is pushed to master already. Should this be accepted?