Differential D10083

[Look and Feel] Reverse the button order
AbandonedPublic
Actions

Authored by safaalfulaij on Jan 24 2018, 6:13 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

The look and feel KCM is using a different button order than other KCMs, which is
inconsistent.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
safaalfulaij created this revision.Jan 24 2018, 6:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2018, 6:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
safaalfulaij requested review of this revision.Jan 24 2018, 6:13 PM
safaalfulaij added a comment.EditedJan 24 2018, 6:17 PM

Look and feel before:

Look and feel after:

Other KCMs:

davidedmundson accepted this revision.Jan 25 2018, 7:38 AM
davidedmundson added a subscriber: davidedmundson.

Do you have commit access?

This revision is now accepted and ready to land.Jan 25 2018, 7:38 AM
safaalfulaij added a comment.Jan 25 2018, 7:54 AM

Yes I do.
But shall we ask VDG or not?

safaalfulaij updated this revision to Diff 25924.Jan 25 2018, 8:25 AM

Align the warning text to the right

davidedmundson requested changes to this revision.Jul 11 2018, 12:46 PM

Is this now redundant when this KCM was remodelled ?

This revision now requires changes to proceed.Jul 11 2018, 12:46 PM
abetts added a subscriber: abetts.Jul 11 2018, 3:01 PM

Not sure it is redundant but it should follow what the mockups in pholio are saying.

ngraham added a subscriber: ngraham.Jan 2 2019, 5:15 AM

This is obsolete now since the button layout was recently made consistent across all KCMs (we put everything on the right). You can Abandon this.

abetts added a comment.Jan 2 2019, 5:17 AM
In D10083#384946, @ngraham wrote:

This is obsolete now since the button layout was recently made consistent across all KCMs (we put everything on the right). You can Abandon this.

Agreed

safaalfulaij abandoned this revision.Jan 3 2019, 7:40 AM

Thanks for making stuff consistent! :)

Revision Contents
Changeset List

Diff 25924

View Options

kcms/lookandfeel/package/contents/ui/main.qml

Loading...