There's no point in showing a gazillion, however, when the number gets bigger, let the circle become pill-shaped.
While at it, also locale-format the number (e.g. thousand separator)
Details
Details
- Reviewers
hein - Group Reviewers
Plasma VDG - Commits
- R119:2edca0b16860: [Task Manager] Let badge become pill-shaped and limit to 0 through 9,999 items
Before
After
In preparation for D9825 the badge with its sizing/radius logic is moved into a separate component
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Why not expand the badge to become pill-shaped so we can accommodate absurdly numbers? That's what macOS does. You might be surprised by now many people have 1000+ unread emails...
Comment Actions
That looks really good!
applets/taskmanager/package/contents/ui/Badge.qml | ||
---|---|---|
32 | Components shouldn't specify their own height, nor should they assume stuff about their parents, it makes them non-portable. I would get rid of this line. Maybe specify an implicitHeight of: label.implicitHeight. Apperance will remain identical as you're overwriting the height on line 79 of TaskBadgeOverlay | |
48 | Why 0 instead of a negative? |