Works in plasma, did not test it with other DEs where notifications might work differently
Details
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- commands
- Lint
No Linters Available - Unit
No Unit Test Coverage
Let the other device know that it can add commands. Prevents newer Android Clients to show functionality that is not yet there on the desktop
I'm unsure about this one. Could it become a security liability?
Having 1 of the systems compromised on the network will escalate on every device very easily with this...
What use-case are you thinking about solving?
I see your point. Right now, the UI to add a command is quite hidden. Most users probably don't even know that there is the Commands Plugin, and without adding commands its pretty useless. Maybe we could ask for the user to confirm the sent command in the desktop. What do you think about this?
A confirmation on the desktop would be a solution... but I also think that otherwise this could be dangerous. As of now, in KDE Connect there is no way to execute arbitrary commands on the other machine, so even if a device is compromised there isn't much it can do to the connected devices. With this patch, we are adding a way to execute anything we want on the other device.
plugins/kdeconnect.notifyrc | ||
---|---|---|
729 | maybe clarify to confirmAddCommand |
plugins/runcommand/runcommandplugin.cpp | ||
---|---|---|
63 | is a return true; missing here? |
plugins/runcommand/runcommandplugin.cpp | ||
---|---|---|
129 | config()->set(...) in addCommand already calls sendConfig() through the configChanged signal |
@apol @albertvaka @mtijink can somebody please test if this works? It doesn't work for me out of nowhere. Looks like the slot in line 128 is never called.