currently shows a passive notification when a track fail to play
the name of the track is currently an url that is not easy to understand
astippich |
Elisa |
currently shows a passive notification when a track fail to play
the name of the track is currently an url that is not easy to understand
If I have a track where I force it to be in error (truncate to 0 size), the notification shows
No Linters Available |
No Unit Test Coverage |
I tried the patch by deleting tracks that are currently in the playlist. Notification works good.
I found another bug during testing, but I think it's unrelated to this revision. I added an album to the playlist and started playback. Then deleted the whole album folder. When you want to start playback of another track it throws the error. Then it tries the next track which also throws an error. The issue is that it does not stop at the end of the playlist, but instead but restarts at the first entry, and then repeats forever
src/PassiveNotification.qml | ||
---|---|---|
21 | why do you import it this way? also works without "as QQC2" here and shouldn't be needed, since no controls 1 are imported, or am I wrong? |
src/PassiveNotification.qml | ||
---|---|---|
21 | This file is imported from Kirigami2 with some modifications when needed. |
I am trying to identify and fix the reason why tracks are not put invalid in the playlist when they are removed from database. This will involve adding more automatic tests. Do you also want to review the c++ only modifications I do ?