Deprecate KStandardAction::PasteText and KPasteTextAction
ClosedPublic

Authored by elvisangelaccio on Aug 13 2017, 4:34 PM.

Details

Summary

The PasteText standard action creates a KPasteTextAction rather than a
QAction. However KPasteTextAction has not been functional for years
(it's supposed to integrate Klipper in the toolbar, but it doesn't).

We already have KStandardAction::Paste which is widely used,
while according to lxr, there is only one usage of PasteText and 3 of
pasteText(). There is no reason to have two standard actions that do
the same thing, so mark PasteText as deprecated.

Diff Detail

Repository
R265 KConfigWidgets
Branch
deprecate-pastetext
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 13 2017, 4:34 PM
elvisangelaccio abandoned this revision.Aug 13 2017, 5:10 PM

I was wrong, this action is needed for KPasteTextAction.

I was wrong, this action is needed for KPasteTextAction.

Re-opening, KPasteTextAction is not functional.

elvisangelaccio reclaimed this revision.Aug 18 2017, 3:32 PM
  • Also deprecate KPasteTextAction
elvisangelaccio retitled this revision from Deprecate KStandardAction::PasteText to Deprecate KStandardAction::PasteText and KPasteTextAction.Aug 18 2017, 3:33 PM
elvisangelaccio edited the summary of this revision. (Show Details)
elvisangelaccio edited the summary of this revision. (Show Details)Aug 18 2017, 3:36 PM
elvisangelaccio edited the summary of this revision. (Show Details)Aug 18 2017, 4:21 PM
elvisangelaccio edited the summary of this revision. (Show Details)
  • Bump @since
dfaure accepted this revision.Sep 10 2017, 2:21 PM
This revision is now accepted and ready to land.Sep 10 2017, 2:21 PM
This revision was automatically updated to reflect the committed changes.