Do not show reveal password button on login screen
ClosedPublic

Authored by siteshwarv on Aug 31 2017, 1:18 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Workspaces
Summary

Reveal password button on the login screen is unnecessary. It can be clicked accidentally and is confusing to the users. Related bug https://bugzilla.redhat.com/show_bug.cgi?id=1487169

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
siteshwarv created this revision.Aug 31 2017, 1:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 31 2017, 1:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Personally, I believe that the reveal password feature should stay. There's an eye icon shown in the password field too IIRC(just checked my lock screen) and I'm puzzled how that can be confusing.

So the killer issue from your bug report is that there's no "eye" icon in your SDDM login. That definitely is a big problem and needs a solution.

But just removing the setting isn't really trying to address the actual bug at all, it's just avoiding it.

mart added a subscriber: mart.Sep 1 2017, 9:44 AM

-1 as well, icon should be fixed

I have talked to other people who use sddm on other distros where eye icon is visible. Despite of the eye icon being visible in the password box, people accidentally click it and it takes some time before they realize it. I would prefer to remove it from the login screen.

davidedmundson accepted this revision.Nov 28 2017, 8:40 PM

We also have bug 387418. And we don't have kiosk restrictions in SDDM either.

Given the rationale for introducing it was very thin, in the first place. I'm going to merge this.
I'd like to revert it in the lock screen too.

This revision is now accepted and ready to land.Nov 28 2017, 8:40 PM
rdieter added a subscriber: rdieter.EditedDec 1 2017, 2:18 PM

If you're going to do this, may as well undo all of https://phabricator.kde.org/D3616 , and remove the reveal password button from the lockscreen too ? Or not... at least the eye icon works there (for me at least).

romangg closed this revision.Jun 13 2018, 9:52 AM
romangg added a subscriber: romangg.

Superseded by D9040.