Allows to show the password on click, similar to how it's done in most other password fields throughout the workspace.
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
On one hand: Yea, why not.
On the other imagine the following situation: Two people sit in front of the PC, and one of them wants to login to the PC. After entering his password, he accidently hits the "show password" icon (since it's pretty near to the "Unlock"-Button. His password has been compromised in this moment and he needs to change it now. In a company setting it could get really ugly, if only an admin is able to. Or if the user is not able to (my mum). Login passwords are in general more undisclosed than for example Wlan passwords (which every second guy coming over for lunch would get from me ... I know it's bad).
Comment Actions
Using that argument, we would have to remove the 'reveal password' option from KPasswordDialog, too.
Comment Actions
One thing we perhaps should do is add a kiosk restriction to globally disable this button everywhere.
Comment Actions
+1 for the patch (I don't think the icon is close enough to the login button to be problematic)
Also +1 for disabling "show password" buttons in general via Kiosk