Differential D7559

Use KActionCollection::setDefaultShortcut
ClosedPublic
Actions

Authored by heikobecker on Aug 26 2017, 3:14 PM.

Details

Reviewers
chehrlic
Group Reviewers
KDE Games
Commits
R423:842161dfac6d: Give QActions a parent
R423:dc5a427fe6af: Use KActionCollection::setDefaultShortcut
Summary

...instead of QAction::setShortcut, which removes some run-time warnings.

Test Plan

Build and checked that shortcuts still work

Diff Detail

Repository
R423 Palapeli
Branch
frameworks
Lint
No Linters Available
Unit
No Unit Test Coverage
heikobecker created this revision.Aug 26 2017, 3:14 PM
chehrlic added a subscriber: chehrlic.Aug 26 2017, 4:06 PM

While you're at it - can you please give all create QActions 'this' as parent? KActionCollection::addAction() does not take ownership of the QAction*

heikobecker updated this revision to Diff 18825.Aug 26 2017, 7:03 PM
  • Give QActions a parent
ltoscano added a subscriber: ltoscano.Aug 26 2017, 9:34 PM

Looks fine by me; I guess that if @chehrlic agrees that the issue that he raised is addressed, this can be approved.

chehrlic accepted this revision.Aug 27 2017, 6:10 AM

Yes, all fine from my side

This revision is now accepted and ready to land.Aug 27 2017, 6:10 AM
Closed by commit R423:dc5a427fe6af: Use KActionCollection::setDefaultShortcut (authored by heikobecker). · Explain WhyAug 27 2017, 7:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/window/mainwindow.cpp (33 lines)

Diff 18825

View Options

src/window/mainwindow.cpp

Loading...