Cancle renaming, such as in scrolling with the scroll bar

Windows Explorer is doing it differently: Renaming is confirmed as soon as scrolling starts. On macOS, Finder allows scrolling and confirms once the file disappears from the viewport.

Finder's implementation doesn't sound too bad, but maybe Dolphin's current behaviour of not moving the rename field is intentional? You'd have to ask the Dolphin folks (IRC, kfm-devel list, tag someone on Phab) about that and what they prefer.

BTW, are you aware of https://bugs.kde.org/show_bug.cgi?id=378786?

since Bugzilla and Maniphest are there to report bugs, which one should we prefer? Or, as a developer, should we go for a diff directly?

Not sure whether we have an official stance on this, but personally I like Phab much more as the interface is more modern and the crossreferencing is so convenient.

I'd say if you just want to report a bug as a user or as a developer, use Bugzilla (it will still be around for a while and has better searching). If you are actively working on something and need a space for organizing notes or for coordination/planning, open a task on a suitable workboard like you did here.

Of course there's no formal requirement (at least in most parts of KDE) to open a task for every Diff, so you could also just create a somewhat complete patch (could even have [WIP] in the title) and work from there.

This definitely resolves 378786. Not sure whether 331236is a duplicate of it, or whether something else is needed there. @akrutzler, could you confirm?

Generally the culture is to use Bugzilla for reporting bugs and Phabricator for submitting patches. That may change in the future, but for now, that's how it's done.

If you have a patch, you don't need to submit a bugzilla ticket to go along with it if one doesn't already exist (but do search among them to see if your patch fixes any of them!).

@ngraham Not sure adding BUG: to a task will work, as the commit hook responsible for closing the bug will be triggered by an actual commit including this with no relation to Phab and its tasks at all.

As for resolving any of the bugs, we should be careful that we won't just hide the underlying issue here. There might still be a problem lurking which is not solved by just modifying scrolling. Note the bug is not only about scrolling, but about a different item getting renamed, i.e. there might be other situations where this also happens. I was just mentioning the bug to point out there is something fishy going on with inline renaming.

Oh haha I didn't notice that this was a task and not a patch. Phooey. Yeah, we should close this task because we already have a Bugzilla ticket tracking the issue (as well as other related ones).

Let's just let Andreas decide where he wants to discuss his work :)

Windows Explorer is doing it differently: Renaming is confirmed as soon as scrolling starts. On macOS, Finder allows scrolling and confirms once the file disappears from the viewport.
Finder's implementation doesn't sound too bad, but maybe Dolphin's current behaviour of not moving the rename field is intentional? You'd have to ask the Dolphin folks (IRC, kfm-devel list, tag someone on Phab) about that and what they prefer.

To be honest, I also don't know if that is a bug or a feature, but my first thought was, hm there is something broken. :) Ok, have checked that again and Dolphin also renames it as soon as you scroll with the scroll bar.

BTW, are you aware of https://bugs.kde.org/show_bug.cgi?id=378786?

Ahh i missed that one because i was just looking for related bugs within the "general" group of dolphin.

This definitely resolves 378786. Not sure whether 331236is a duplicate of it, or whether something else is needed there. @akrutzler, could you confirm?

I will have a look at them and and maybe i can find/fix more bugs regarding inline renaming.

I will leave this task open until I have some patch for this. :)

To be honest, I also don't know if that is a bug or a feature, but my first thought was, hm there is something broken. :)

Well, if it looks broken, it probably is a UI bug in some way or another. I find it weird, too.

Ok, have checked that again and Dolphin also renames it as soon as you scroll with the scroll bar.

That's just because you click (anywhere, really, not only on the scrollbar), scrolling with the mouse wheel does not trigger renaming as your video shows and unlike Windows.

That's just because you click (anywhere, really, not only on the scrollbar), scrolling with the mouse wheel does not trigger renaming as your video shows and unlike Windows.

Yeah you are right.

But yes, I'm looking for similar stuff on Bugzilla and hopefully I'll be able to fix it. :)