Multiple datasets for Money activity
Open, Needs TriagePublic

Description

Multiple Datasets have to be implemented for money activity and its sub activities.

  • Money.
    • Money with Cents.
    • Give tux his change.
    • Give tux his change, including cents.

Goal: You must buy the different items and give the exact price. At higher levels, several items are displayed, and you must first calculate the total price.
MultipleData1: Recommended age: 5-6
Goal: You must buy the different items and give the exact price (until 10 euros).
Level 1: You must buy an item and give the exact price (until 4 euros)
Level 2: You must buy an item and give the exact price (until 5 euros)
Level 3: You must buy an item and give the exact price (until 6 euros)
Level 4: You must buy an item and give the exact price (until 7 euros)
Level 5: You must buy an item and give the exact price (until 8 euros)
Level 6: You must buy an item and give the exact price (until 9 euros)
Level 7: You must buy an item and give the exact price (until 10 euros)

MultipleData2: Recommended age: 6-7
Goal: You must buy the different items and give the exact price (until 100 euros).
Level 1: You must buy an item and give the exact price (until 20 euros)
Level 2: You must buy an item and give the exact price (until 30 euros)
Level 3: You must buy an item and give the exact price (until 60 euros)
Level 4: You must buy an item and give the exact price (until 100 euros)
Level 5: You must buy one or more items and give the exact price (until 20 euros)
Level 6: You must buy one or more items and give the exact price (until 30 euros)
Level 7: You must buy one or more items and give the exact price (until 60 euros)
Level 8: You must buy one or more items and give the exact price (until 100 euros)

MultipleData3: Recommended age: 7-10
Goal: You must buy the different items and give the exact price (until 1000 euros).
Level 1: You must buy an item and give the exact price (until 100 euros)
Level 2: You must buy an item and give the exact price (until 300 euros)
Level 3: You must buy an item and give the exact price (until 600euros)
Level 4: You must buy an item and give the exact price (until 1000 euros)
Level 5: You must buy one or more items and give the exact price (until 100 euros)
Level 6: You must buy one or more items and give the exact price (until 300 euros)
Level 7: You must buy one or more items and give the exact price (until 600 euros)
Level 8: You must buy one or more items and give the exact price (until 1000 euros)

Activity: Give Tux his change
Goal: Tux bought different items from you and shows you his money. You must give him back his change. At higher levels, several items are displayed, and you must first calculate the total price.
MultipleData1: Recommended age: 5-6
Level 1: Give Tux his change, the maximum price is 5 (euros/dollards).
random from 1 + ? = 5

Level 2: Tux buys one items, give him his change, he gives you maximum 7 (euros/dollards).
random from 1 + ? = 7 only one element bought

Level 3: Tux buys one items, give him his change, he gives you maximum 9 (euros/dollards).
random from 1 + ? = 9 only one element bought

Level 4: Tux buys one items, give him his change, he gives you maximum 10 (euros/dollards).
random from 1 + ? = 10 only one element bought

Level 5: Tux buys one items, give him his change, he gives you maximum 13 (euros/dollards).
random from 1 + ? = 13 only one element bought

Level 6: Tux buys one items, give him his change, he gives you maximum 15 (euros/dollards).
random from 1 + ? = 15 only one element bought

Level 7: Tux buys one items, give him his change, he gives you maximum 20 (euros/dollards).
random from 1 + ? = 20 only one element bought

MultipleData2: Recommended age: 6-8
Level 1: Tux buys one items, give him his change, he gives you maximum 10 (euros/dollards).
random from 1 + ? = 10 only one element bought

Level 2: Tux buys 2 items, give him his change, he gives you maximum 10 (euros/dollards).
random from 1 + ? = 10 two elements bought

Level 3: Tux buys several items, give him his change, he gives you maximum 10 (euros/dollards).
random from 1 + ? = 10 several elements bought

Level 4: Tux buys 1 item, give him his change, he gives you maximum 20 (euros/dollards).
random from 1 + ? = 20 only one element bought

Level 5: Tux buys 2 items, give him his change, he gives you maximum 20 (euros/dollards).
random from 1 + ? = 20 two elements bought

Level 6: Tux buys several items, give him his change, he gives you maximum 20 (euros/dollards).
random from 1 + ? = 20 several elements bought

Level 7: Tux buys 1 item, give him his change, he gives you maximum 50 (euros/dollards).
random from 1 + ? = 50 only one element bought

Level 8: Tux buys 2 items, give him his change, he gives you maximum 50 (euros/dollards).
random from 1 + ? = 50 two elements bought

Level 9: Tux buys several items, give him his change, he gives you maximum 50 (euros/dollards).
random from 1 + ? = 50 several elements bought

Level 10: Tux buys 1 item, give him his change, he gives you maximum 100 (euros/dollards).
random from 1 + ? = 100 only one element bought

Level 11: Tux buys 2 items, give him his change, he gives you maximum 100 (euros/dollards).
random from 1 + ? = 100 two elements bought

Level 12: Tux buys several items, give him his change, he gives you maximum 100 (euros/dollards).
random from 1 + ? = 100 several elements bought

  1. I would recommend removing the Rupee sign from items, as it's not a standard currency everywhere.
  2. I get this error: qrc:/gcompris/src/core/DialogChooseLevel.qml:275:33: QML Image: Cannot open: qrc:/gcompris/src/core/resource/difficulty0.svg
  3. When we choose a dataset and click on save, I would prefer a message screen showing something like "Selected dataset preference saved". Take at GCCreationHandler when we save something.
  4. When I do "Save and start" and return from the activity, I again see the same dataset selection dialog. I think it would be better if closed when an activity is launched. Needs discussion with other mentors too.
  5. Number of levels don't match as mentioned in the description.
  6. When I'm at some level and click on '?' help icon and close it, I again get back to level 1.
  7. There's a layout issue: https://pasteboard.co/IiaLVjn.png
  8. Another layout issue. See the two notes on Tux: https://pasteboard.co/IiaM6Up.png
  9. I think in "Give Tux his change", for age 5-6 we shouldn't give to calculate and give change directly from Rupees 10 in the 1st level. Maybe a little less?

@amankumargupta , I've fixed issues mentioned in points 5) 7) 8) and 9) you may have a look.
Regarding Issue 1) Since the activity is localized hence you see Rupee sign there as you might have set your language to hindi from language selector. In my case it is set to English UK hence I get Euro sign there.
Regarding Issue 6) I checked it is the case with every activity.

Regarding issues 2, 3 and 4, these issues are related to dataset selection dialog and not with money activity so I planned to take them up all together as mentioned in the proposal from 9 - 20 august. So as to keep the commits separate.
So should I start with that part after money activity or start working on them while working on planned activities only or take them up at the end.
Bit confused :P

AkshayCHD updated the task description. (Show Details)Jun 8 2019, 5:57 AM

I think @jjazeix @timotheegiet and @echarruau would recommend about it better than me :)

As for point 5, I intended to say that in the task you've written age till 5-6 will get 7 levels, but it's 10 in the actual activity. Same goes for other datasets too.

For 6, it's a regression I added with multiple dataset, I'll handle it.

sorry @AkshayCHD for taking time to answer your question "So should I start with that part after money activity or start working on them while working on planned activities only or take them up at the end."
I would say as you planned to look at those issues from 9th to 20th of August, better follow your plan and focus on the current task.

@timotheegiet Sure, will do that :)

AkshayCHD updated the task description. (Show Details)Jun 14 2019, 7:55 AM

For usability, money activities seem good to me :)
Though, can you fix this overriding? : https://pasteboard.co/IjyU3c9.png The bottom note gets overridden by the bar.
And in the same screenshot, we can see that in one of the notes on Tux "10" is not fully visible. Can you move the front note a bit more right?

And I'm not sure to have seen this error before, but seems like a thing which can be concerned with @timotheegiet :
qt.svg: :/gcompris/src/activities/money/resource/n200e.svg:3327:1: Could not resolve property: #pattern5509
qt.svg: :/gcompris/src/activities/money/resource/n200e.svg:3327:1: Could not resolve property: #pattern5517

@amankumargupta : those errors probably just mean some parts of those svg images are not read properly.
Those errors will go when I draw new images anyway, no need to worry about it for now if the images still look ok as placeholder.

@amankumargupta Thanks for the review :) I have fixed the issues that you mentioned in the mockup in the commit https://phabricator.kde.org/R2:4b407c0144849121f8d25ab7f16f4e4c62f99c78 . As for the errors @timotheegiet is right they are related to svgs and will be fixed when svgs are replaced with new ones.

There's a very minor layout issue: https://pasteboard.co/IkCmqlL.png The Rupee sign goes outside the containing area.
Can you fix it?

@amankumargupta I've fixed the issue here, https://phabricator.kde.org/D21841 , or you can pull the branch gsoc_akshaychd_multiple_datasets