PersonsModel: Fix PersonVCardRole
Reviewers: apol, nicolasfella
Reviewed By: nicolasfella
Subscribers: nicolasfella, kde-frameworks-devel
Tags: Frameworks
Differential Revision: https://phabricator.kde.org/D28110
Description
Description
Details
Details
- Committed
jbbgameich Mar 17 2020, 11:31 PM - Reviewer
- nicolasfella
- Differential Revision
- D28110: PersonsModel: Fix PersonVCardRole
- Parents
- R307:6c223afd7671: GIT_SILENT Upgrade KF5 version to 5.69.0.
- Branches
- Unknown
- Tags
- Reverted By
- R307:f88b7d90f240: Revert "PersonsModel: Fix PersonVCardRole"
Comment Actions
I'm sorry, this broke existing code (even in KPeople). Despite the confusing name, PersonVCardRole actually was supposed to return an AbstractContact::Ptr. Should I revert this or is there a better solution?
Comment Actions
This could be an api where TODO KF6 would make sense. We should find a better fitting name for this functionality, like AbstractContactProperty.