Diffusion Baloo b272de480398

Fix ResultIterator

Authored by aacid on Jan 30 2019, 5:06 PM.

Description

Fix ResultIterator

Summary:
Previously it had a copy contructor that just assigned the d pointer
of the rhs to the new object, meaning both objects had the same d pointer
and thus we would end up with a double delete when both got deleted.

Now i've made the copy contructor and assignment operator non existing to have this problem

But we need a move constructor since the class is typically used as

Baloo::ResultIterator it = query.exec();

and that stops working if we delete the regular copy and assignment operators

Reviewers: Baloo, bruns, poboiko, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel, Baloo

Tags: Frameworks, Baloo

Differential Revision: https://phabricator.kde.org/D18237

Details

Committed
aacidJan 30 2019, 5:06 PM
Reviewer
apol
Differential Revision
D18237: Fix ResultIterator
Parents
R293:f4dd3f7bab79: [tags_kio] Disable access with a double slashed url, i.e. "tags://".
Branches
Unknown
Tags
Unknown