| bruns | |
| poboiko | |
| apol |
| Baloo |
Previously it had a copy contructor that just assigned the d pointer
of the rhs to the new object, meaning both objects had the same d pointer
and thus we would end up with a double delete when both got deleted.
Now i've made the copy contructor and assignment operator non existing to have this problem
But we need a move constructor since the class is typically used as
Baloo::ResultIterator it = query.exec();
and that stops working if we delete the regular copy and assignment operators
| No Linters Available |
| No Unit Test Coverage |
| Buildable 7682 | |
| Build 7700: arc lint + arc unit |
Do you think BC is a problem here then? Won't applications be using it as you described start failing?
Hmmm, you're right, this is Source Compatible but not Binary Compatible.
I guess i'll discard this and hope people don't really misuses it.
Maybe it could make sense to deprecate the copy constructor and add the move operator?
The correct way to fix this is by allocating a new ResultIteratorPrivate and "copying" the QStringList.