Rewrite the taglib extractor to use the generic PropertyMap interface

Authored by astippich on Mar 10 2019, 3:02 PM.

Description

Rewrite the taglib extractor to use the generic PropertyMap interface

Summary:
Rewrite the taglib extractor to use taglib's
PropertyMap. Since this largely unifies the handling of the
different tag formats, but not quite, a lot of code is removed.
The resulting code is also faster. Additionally, this avoids the
usage of a FileRef object, which fixes a potential crash due to
a known bug in taglib.

BUG: 403902

Test Plan: all tests pass

Reviewers: ngraham, bruns, mgallien

Reviewed By: bruns

Subscribers: smithjd, kde-frameworks-devel, Baloo

Tags: Frameworks, Baloo

Differential Revision: https://phabricator.kde.org/D18826

Details

Committed
astippichMar 10 2019, 3:02 PM
Reviewer
bruns
Differential Revision
D18826: Rewrite the taglib extractor to use the generic PropertyMap interface
Parents
R286:2585edd21a13: GIT_SILENT Upgrade KF5 version to 5.57.0.
Branches
Unknown
Tags
Unknown