Add more compiler warnings
Concern Raised38fb3b210585

Authored by wojnilowicz on May 7 2018, 6:05 AM.

Description

Add more compiler warnings

Purpose of this patch is to enhance code quality. It also enhances
readability of flags used for different compilers.

Differential Revision: https://phabricator.kde.org/D12737

Details

Auditors
christiand
Committed
wojnilowiczMay 7 2018, 1:55 PM
Differential Revision
D12737: Enable more compiler warnings
Parents
R261:9a4f7ab07154: Keep context menu at cursor position
Branches
Unknown
Tags
Unknown
christiand raised a concern with this commit.May 12 2018, 12:59 PM
christiand added a subscriber: christiand.
christiand added inline comments.
/CMakeLists.txt
287

Do not use CMAKE_BUILD_TYPE in this context. Just set the CMAKE_CXX_FLAGS_… without the if.

This commit now has outstanding concerns.May 12 2018, 12:59 PM
wojnilowicz marked an inline comment as done.May 12 2018, 4:06 PM