christiand (Christian David)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:27 AM (166 w, 15 h)
Availability
Available

Recent Activity

Sun, Jun 10

christiand accepted D13295: Enable foreign keys support in SQLite.
Sun, Jun 10, 10:24 AM · KMyMoney
christiand committed R261:2400f611ba38: Added currency Cuban Convertible Peso (CUC) (authored by christiand).
Added currency Cuban Convertible Peso (CUC)
Sun, Jun 10, 10:18 AM

May 16 2018

christiand resigned from D12808: Refactor MyMoneyException class.

[…] so what's left is:

  1. Untranslated excepctions, as normal user doesn't need to understand exceptions, only developers do,
May 16 2018, 7:30 PM · KMyMoney

May 13 2018

christiand accepted D12844: Fix setup for for multi profile build generators.
May 13 2018, 10:20 AM

May 12 2018

christiand accepted D12836: Format headers according to the KDE guidelines.

I like this very much!

May 12 2018, 4:31 PM · KMyMoney
christiand added a comment to D12808: Refactor MyMoneyException class.

I understand that it allows us to distinguish between exceptions but who should handle exceptions that we can't handle?
I think it's our duty to do that, because some library throws it at us, because we acted on it in some way, so we are here to blame, so we should handle it.
Just passing exception beyond our application doesn't make the issue go away.
In my opinion, we should know every exception that is being thrown at us, so that we can be aware, even if we aren't prepared from the outset for it.

May 12 2018, 4:30 PM · KMyMoney
christiand accepted D12758: Reenable storing of payeeIdentifier in SQL storage.
May 12 2018, 2:55 PM · KMyMoney
christiand raised a concern with R261:d1ef13e4ab9e: Set necessary flag for debug builds.
May 12 2018, 1:03 PM
christiand raised a concern with R261:38fb3b210585: Add more compiler warnings.
May 12 2018, 12:59 PM
christiand committed R261:f724738bf741: Minor code improvements (authored by christiand).
Minor code improvements
May 12 2018, 12:32 PM
christiand added a comment to D12758: Reenable storing of payeeIdentifier in SQL storage.

Why was it disabled in the first place if the fix is that easy?

May 12 2018, 12:16 PM · KMyMoney
christiand requested changes to D12808: Refactor MyMoneyException class.

actually I liked the separate class for exception handling. It allows to distinguish between issues within KMyMoney and outside of it. Typically we do not/cannot handle things like std::bad_alloc so the “missing” catch is desired. Also there is some code which expects this behavior (I think the onlineJob casting stuff), just replacing everything is dangerous. You could inherit MyMoneyException from std::runtime_error. Then we can knowingly change the catches where it is useful and safe.

May 12 2018, 12:15 PM · KMyMoney
christiand added a comment to D12759: Fix saving and opening of SQL storage.

I am not into this code, so I can only give general advice.

May 12 2018, 11:41 AM · KMyMoney

Apr 22 2018

christiand accepted D12412: Fix working week.

Did not test, but looks good! Can you push yourself?

Apr 22 2018, 9:21 AM · KMyMoney
christiand added inline comments to D10614: Custom icons for accounts.
Apr 22 2018, 9:17 AM · KMyMoney

Apr 21 2018

christiand requested changes to D12412: Fix working week.
Apr 21 2018, 9:08 PM · KMyMoney
christiand accepted D12412: Fix working week.
Apr 21 2018, 9:05 PM · KMyMoney

Apr 9 2018

christiand added a comment to D11841: Pluginize KOnlineJobOutbox.

I don't like it. Dynamic plugins offer me separation of code, build and run speed.

Apr 9 2018, 8:04 PM · KMyMoney

Apr 8 2018

christiand added inline comments to D11841: Pluginize KOnlineJobOutbox.
Apr 8 2018, 9:07 AM · KMyMoney
christiand added a comment to D11841: Pluginize KOnlineJobOutbox.

I don't know this problem, because I don't use this view. I think that packaging error is not our business. I think the view should contain more of online job bits but for know it's all that's easy to separate from the rest.

Apr 8 2018, 9:04 AM · KMyMoney

Apr 7 2018

christiand added a comment to D11841: Pluginize KOnlineJobOutbox.

I want to raise a usability concern. If the user is using the online banking and this page gets disabled (e.g. accidentally, packaging error, some other error) KMyMoney still offers to queue transactions. However, without this plugin the transaction seems to be lost. Queued transactions are also kept during restarts. This could lead to further trouble if the queue is sent after the user forgot about the (hidden) transaction(s).

Apr 7 2018, 9:42 AM · KMyMoney

Mar 26 2018

christiand committed R261:dae9b9045a52: Coding Style: Use CMake commands lower case only (authored by christiand).
Coding Style: Use CMake commands lower case only
Mar 26 2018, 6:43 PM

Feb 4 2018

christiand committed R261:3885b4b1b128: Silence CMake warning about policy CMP0071 (authored by christiand).
Silence CMake warning about policy CMP0071
Feb 4 2018, 2:42 PM
christiand committed R261:09ffa40aa038: Silence CMake warning about policy CMP0071 (authored by christiand).
Silence CMake warning about policy CMP0071
Feb 4 2018, 2:39 PM
christiand closed D10162: Silence CMake warning about policy CMP0071.
Feb 4 2018, 2:39 PM
christiand committed R261:d7f0d2cadbfa: Moved some code from main() to runKMyMoney() (authored by christiand).
Moved some code from main() to runKMyMoney()
Feb 4 2018, 2:10 PM
christiand added a comment to D10162: Silence CMake warning about policy CMP0071.

I found a new warning which is generated by this patch. However, I would leave it as it is, because there will be a warning or we may miss when a change to CMake 3.10 becomes mandatory.

Feb 4 2018, 1:45 PM

Feb 3 2018

christiand requested changes to D10043: Pass MP include header location detected at client configure time to clients.

Hi Thomas,

Feb 3 2018, 3:56 PM · KMyMoney

Jan 30 2018

christiand committed R261:1ca1072eec74: Fixed some krazy warnings (authored by christiand).
Fixed some krazy warnings
Jan 30 2018, 7:07 PM
christiand added a comment to D10164: Revert "Fix check for cpp macros and usage".

If your questioning of krazy correctness will be accepted by krazy maintainer Allen Winter, then I am in for this patch.

Jan 30 2018, 6:55 PM
christiand added inline comments to R261:44f846f13d0f: Make compilation work on MSVC 2017.
Jan 30 2018, 6:44 PM
christiand raised a concern with R261:6ebe577d80ee: Fix check single-char QString operations for efficiency.
Jan 30 2018, 6:27 PM
christiand raised a concern with R261:44f846f13d0f: Make compilation work on MSVC 2017.

The first two notes are not so important but the corresponding code should get a /**@todo */ comment.

Jan 30 2018, 6:17 PM

Jan 29 2018

christiand added a comment to D10164: Revert "Fix check for cpp macros and usage".

I have some questions for that:

  1. As I see correctly, that brings us warning by our code checker krazy back. What for?
Jan 29 2018, 8:21 PM

Jan 28 2018

christiand added a comment to D10162: Silence CMake warning about policy CMP0071.

I saw once, that the OLD behavior may cause other warnings. However, I cannot reproduce this. Since I am not able to push currently, I will observe this and push later (to branch 5.0).

Jan 28 2018, 7:38 PM
christiand updated the diff for D10162: Silence CMake warning about policy CMP0071.

Reverted last change - I am fighting with arc :(

Jan 28 2018, 7:13 PM
christiand updated the diff for D10162: Silence CMake warning about policy CMP0071.
Jan 28 2018, 6:54 PM
christiand abandoned D9710: Allow to load Plugins without installing them.
Jan 28 2018, 4:21 PM · KMyMoney
christiand updated the diff for D9710: Allow to load Plugins without installing them.

Corrected build location of checkprinting plugin

Jan 28 2018, 4:11 PM · KMyMoney

Jan 10 2018

christiand added a comment to D9710: Allow to load Plugins without installing them.

From my point of view, the only issue left is the line QCoreApplication::addLibraryPath(QCoreApplication::applicationDirPath() + QDir::separator() + "kmymoney-plugins");. Since this seems to be a highly emotional question so I do not think further discussions are of use here.

Jan 10 2018, 6:40 PM · KMyMoney

Jan 9 2018

christiand committed R261:c7036d1eca36: Extended timeout in reports-chart test (authored by christiand).
Extended timeout in reports-chart test
Jan 9 2018, 9:01 PM
christiand added a comment to D9710: Allow to load Plugins without installing them.

[…]
Why do you want to eliminate installing? On my machine it takes like less than second and my machine isn't at any point fast.
Why is setting environment variable so upsetting? I've set it once and it isn't impacting my speed or my time.

Jan 9 2018, 8:25 PM · KMyMoney

Jan 7 2018

christiand retitled D9710: Allow to load Plugins without installing them from Allow to start KMyMoney with plugins from build directory to Allow to load Plugins without installing them.
Jan 7 2018, 2:45 PM · KMyMoney

Jan 5 2018

christiand added inline comments to R261:21338733baca: New plugins loading system.
Jan 5 2018, 5:59 PM

Jan 3 2018

christiand committed R261:f3e2b15196e2: Use QTest in report's chart-test (authored by christiand).
Use QTest in report's chart-test
Jan 3 2018, 4:15 PM
christiand committed R261:04cf9683e94c: Explicitly name files in CMakeLists for reports/test (authored by christiand).
Explicitly name files in CMakeLists for reports/test
Jan 3 2018, 4:15 PM

Dec 3 2017

christiand committed R261:fcb0c3768b8a: Fixed compile error under certain configurations (authored by christiand).
Fixed compile error under certain configurations
Dec 3 2017, 10:15 PM
christiand added a comment to D9148: Port NetAccess to KF5.

Hi Olivier,

Dec 3 2017, 10:02 PM
christiand committed R261:a68ab2a99c5d: Fixed bug in models test (authored by christiand).
Fixed bug in models test
Dec 3 2017, 9:48 PM
christiand committed R261:eda619db7e44: Removed reviewboard config file (authored by christiand).
Removed reviewboard config file
Dec 3 2017, 9:48 PM
christiand committed R261:37ea0cb9fd3a: Improved CMakeLists.txt for models (authored by christiand).
Improved CMakeLists.txt for models
Dec 3 2017, 9:48 PM
christiand added a comment to D9106: Create d-pointer for MyMoneyObject.

Hi! Did you do a performance comparison? I am concerned that this patch can reduce performance significantly because some of the objects are created very often and in huge amounts. Additionally we perform searches with them. Also I am not sure if these very simple objects (often POD) can really benefit from a d-pointer, except ABI stability. The drawback is increased code complexity.

Dec 3 2017, 12:36 PM · KMyMoney

Nov 5 2017

christiand added a comment to D8665: Create d-pointer for LedgerModel.

Wow, this is an impressive huge amount of work.

Nov 5 2017, 12:31 PM · KMyMoney

Oct 29 2017

christiand requested changes to D8506: add some more autogenerated files to .gitignore.

This is not needed if you build out of source or the name of your build directory matches the first entry in .gitignore which is 'build*/'. On the other hand, it does not hurt either.

Oct 29 2017, 7:24 AM

Sep 17 2017

christiand committed R261:b66832b07662: Cosmetics to CMakeLists.txt (authored by christiand).
Cosmetics to CMakeLists.txt
Sep 17 2017, 12:42 PM

Jun 29 2017

christiand added a comment to D6384: Switch to c++14.

[…]
and using the proposed change does not work. Not sure if there is a newer version available and how I would install and not brake anything.

Jun 29 2017, 5:47 AM · KMyMoney

Jun 26 2017

christiand added a comment to D6384: Switch to c++14.

I am with Łukasz. If all developers can compile KMyMoney I am all in. I would not worry about the distros because until we can release this version this won't be an issue anymore.

Jun 26 2017, 7:28 PM · KMyMoney

Jun 19 2017

christiand added a comment to D6166: Use Int instead of QString in TableRow.

Your changes improve the code a lot! They make this code better in so many ways, thank you!

Jun 19 2017, 7:12 PM · KMyMoney

Jun 1 2017

christiand added a project to R261:398304bcf331: Update memo in the other split if requested: KMyMoney.
Jun 1 2017, 5:00 PM · KMyMoney
christiand added a comment to R261:398304bcf331: Update memo in the other split if requested.

[…]

Jun 1 2017, 4:53 PM · KMyMoney

May 31 2017

christiand committed R261:503617e105d7: Removed outdated german bankdata (authored by christiand).
Removed outdated german bankdata
May 31 2017, 8:28 PM
christiand committed R261:2d7752f1dce7: Fixed race condition in build system (authored by christiand).
Fixed race condition in build system
May 31 2017, 8:28 PM
christiand raised a concern with R261:398304bcf331: Update memo in the other split if requested.

Hello Lukasz,

May 31 2017, 7:47 PM · KMyMoney
christiand committed R261:c32e890e9c79: Removed outdated german bankdata (authored by christiand).
Removed outdated german bankdata
May 31 2017, 6:56 PM

Apr 29 2017

christiand added a comment to D5655: Remove the backup function.

I don't like this idea. In the moment there is no third part app to backup KMM, so there will be no backup feature at all.
Moreover I don't get why it must be third part app and not KMM.

Apr 29 2017, 4:42 PM · KMyMoney
christiand updated the summary of D5655: Remove the backup function.
Apr 29 2017, 3:24 PM · KMyMoney
christiand created D5655: Remove the backup function.
Apr 29 2017, 3:23 PM · KMyMoney
christiand committed R261:21f151b47834: Cosmetics in KBalanceChartDlg (authored by christiand).
Cosmetics in KBalanceChartDlg
Apr 29 2017, 12:51 PM
christiand committed R261:3c5a9a61de8a: Last step of porting KNewUserWizard to KF5 (authored by christiand).
Last step of porting KNewUserWizard to KF5
Apr 29 2017, 12:51 PM

Apr 26 2017

christiand committed R261:7064cb1a4406: Removed unused functions for timers from main() (authored by christiand).
Removed unused functions for timers from main()
Apr 26 2017, 8:19 PM

Apr 23 2017

christiand committed R261:bc9c7202c311: Removed profile depended define in config-kmymoney.h (authored by christiand).
Removed profile depended define in config-kmymoney.h
Apr 23 2017, 12:11 PM
christiand committed R261:0bb419447b04: Ported KGenerateSqlDlg to KF5 (authored by christiand).
Ported KGenerateSqlDlg to KF5
Apr 23 2017, 12:02 PM
christiand committed R261:18a3a11096f1: Ported KSelectDatabaseDlg to KF5 (authored by christiand).
Ported KSelectDatabaseDlg to KF5
Apr 23 2017, 12:02 PM
christiand committed R261:a404b3b64940: Simplified CMakeLists.txt (authored by christiand).
Simplified CMakeLists.txt
Apr 23 2017, 12:02 PM

Apr 18 2017

christiand committed R261:b1468e678e5f: Added required version for Qt (authored by christiand).
Added required version for Qt
Apr 18 2017, 4:46 PM

Feb 18 2017

christiand added a comment to D4655: Add range tab to chart reports.

Christian - I think the reason is in the original bug "... changes in e.g. investments with large different values are hardly to recognize on a linear scale (e.g. change of 20 to 10 if you have a graph changing from 150 to 70)." I'd probably like to see some actual examples of cases where it makes sense, but I don't see any reason against doing it.

Feb 18 2017, 1:19 PM · KMyMoney
christiand added inline comments to D4656: Use price precision setting on investment prices report.
Feb 18 2017, 12:38 PM · KMyMoney

Feb 17 2017

christiand added a comment to D4655: Add range tab to chart reports.

Well this is not very convincing to me, whatever.

Feb 17 2017, 9:03 PM · KMyMoney
christiand added a comment to D4655: Add range tab to chart reports.

I am just curious, why should an app for private finance should have a logarithmic axis? This does not sound useful to me.

Feb 17 2017, 8:57 PM · KMyMoney
christiand added inline comments to D4656: Use price precision setting on investment prices report.
Feb 17 2017, 8:54 PM · KMyMoney
christiand added inline comments to R261:d56fe898abc4: Add Capital Gains report.
Feb 17 2017, 7:27 PM

Nov 6 2016

christiand added a watcher for KMyMoney: christiand.
Nov 6 2016, 12:06 PM
christiand added a member for KMyMoney: christiand.
Nov 6 2016, 12:05 PM