Purpose of this patch is to enhance code quality. It also enhances readability of flags used for different compilers.
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:38fb3b210585: Add more compiler warnings
Tested on GCC only. Compiling on Clang 6 fails for me, even before the patch.
Does anybody use DebugKMM, Debugfull or Profile? It seems useless to me, so I would like to remove it.
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Running this with
g++-6 (SUSE Linux) 6.2.1 20160826 [gcc-6-branch revision 239773]
produces a whole bunch of different (and useful as far as I have seen) warnings. And yes, I use DebugKMM, Debugfull or Profile from time to time (mostly Debugfull) so they should stay.
| CMakeLists.txt | ||
|---|---|---|
| 270 | Missing quote after as-needed here. | |
Comment Actions
Ok. Feel free to add any warning you'd like. I feel, they can make us only good.
| CMakeLists.txt | ||
|---|---|---|
| 270 | Sharp sight! :) I see that this conditional branch was from previous version of the patch, so it doesn't exist anymore. | |