Diffusion Solid 3adf5d472448

[Fstab] Do not emit deviceAdded twice on fstab/mtab changes

Authored by bruns on Apr 12 2020, 5:50 PM.

Description

[Fstab] Do not emit deviceAdded twice on fstab/mtab changes

Summary:
The deviceAdded signal was emitted twice, once with the old device list
in m_deviceList, once with the new one.

The first one is actually wrong and was fixed in kdelibs4 by moving the
deviceAdded signal after the m_deviceList update. In KF5, the second
signal was added but the first one never removed.

Move the m_deviceList update to the top (though for deviceRemoved it
does not matter much), and remove the second signal.

Depends on D28779

Test Plan:

  1. solid-hardware listen
  2. add an entry to the fstab

-> deviceAdded is only emitted once

Reviewers: Frameworks, afiestas, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D28782

Details

Committed
brunsApr 13 2020, 10:31 AM
Reviewer
apol
Differential Revision
D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes
Parents
R245:62de28267684: [Fstab] Use new style connect API
Branches
Unknown
Tags
Unknown