| afiestas | |
| apol |
| Frameworks |
The deviceAdded signal was emitted twice, once with the old device list
in m_deviceList, once with the new one.
The first one is actually wrong and was fixed in kdelibs4 by moving the
deviceAdded signal after the m_deviceList update. In KF5, the second
signal was added but the first one never removed.
Move the m_deviceList update to the top (though for deviceRemoved it
does not matter much), and remove the second signal.
Depends on D28779
-> deviceAdded is only emitted once
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/solid/devices/backends/fstab/fstabmanager.cpp | ||
|---|---|---|
| 122 | The debug seems wrong and probably unnecessary. I'd remove it. | |
| src/solid/devices/backends/fstab/fstabmanager.cpp | ||
|---|---|---|
| 122 | What do you think is wrong with it? And its the only debug output there is on this level, and always having to add debug statements in case of errors and then recompile it to get some traces is quite suboptimal. You can't ask a regular user to do it, and its silent by default. | |