Diffusion KIO c9bbe188c9f3

KPropertiesDialog: port KRun::run to ApplicationLauncherJob

Authored by dfaure on Mar 29 2020, 10:38 AM.

Description

KPropertiesDialog: port KRun::run to ApplicationLauncherJob

Summary:
KRun::run(exec, urls) is somewhere in between the two jobs.
Since we know the name of the desktop file, we might as well use ApplicationLauncherJob here.
Otherwise we would probably need a bit of KShell escaping to turn a QUrl into a command-line arg.

Test Plan:
With filelight installed, the button in the properties dialog works.
With the .desktop file still installed but the executable renamed, an error message pops up as expected.

Reviewers: davidedmundson, broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D28266

Details

Committed
dfaureMar 29 2020, 10:38 AM
Reviewer
broulik
Differential Revision
D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob
Parents
R241:01a4b70803d5: API docs: mention using delegates for error handling
Branches
Unknown
Tags
Unknown