KPropertiesDialog: port KRun::run to ApplicationLauncherJob
Needs ReviewPublic

Authored by dfaure on Wed, Mar 25, 12:15 AM.

Details

Summary

KRun::run(exec, urls) is somewhere in between the two jobs.
Since we know the name of the desktop file, we might as well use ApplicationLauncherJob here.
Otherwise we would probably need a bit of KShell escaping to turn a QUrl into a command-line arg.

Test Plan

With filelight installed, the button in the properties dialog works.
With the .desktop file still installed but the executable renamed, an error message pops up as expected.

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24190
Build 24208: arc lint + arc unit
dfaure created this revision.Wed, Mar 25, 12:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Mar 25, 12:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Wed, Mar 25, 12:15 AM