Diffusion KIO 371e523f5d7e

Correctly encode URL of thumbnails

Authored by davidedmundson on Apr 12 2018, 9:06 AM.

Description

Correctly encode URL of thumbnails

Summary:
As per the amazingly detailed bug report, the spec says URLs should be
percent encoded. The main knock-on effect is we get a different hash
value for our preview file and we duplicate thumbnails if a user uses a
GNOME app.

BUG: 393015

Test Plan:
Logged out and back in
Copied jpeg to a file with spaces
opened dolphin
Found relevant cache file in ~/.cache/thumbnails/normal based on timestamp
exiftool showed the correct URI.

Thumb URI : file:///tmp/with%20spaces.jpg

I assume the hash is now "correct" but I don't have a way to check

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: ngraham, Frameworks

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D12133

Details

Committed
davidedmundsonApr 12 2018, 8:35 PM
Reviewer
ngraham
Differential Revision
D12133: Correctly encode URL of thumbnails
Parents
R241:e504bc1fd564: Tweak column widths in tree view of file open/save dialogs
Branches
Unknown
Tags
Unknown