Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
b7a63491ad1c
Actions

Authored by davidedmundson on Aug 18 2017, 10:18 AM.

Description

Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

Summary:
Nested classes inherit the visibility of their outer class,
so all the KClass::Private symbols have also been exported
if the ones of KClass were.

Test Plan:
Ran nm -DC to list symbols
Only changed visibility of classes defined in .cpp files, so no client code should be affected.

Reviewers: Plasma, dfaure

Reviewed By: dfaure

Subscribers: plasma-devel, Frameworks

Tags: Plasma on Wayland, Frameworks

Differential Revision: https://phabricator.kde.org/D7304

Details

Committed

davidedmundson

Aug 18 2017, 10:43 AM

Reviewer

dfaure

Differential Revision

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

Parents

R127:1b2794985361: Avoid sending data offers from an invalid source.

Branches

Unknown

Tags

Unknown

davidedmundson committed R127:b7a63491ad1c: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (authored by davidedmundson).Aug 18 2017, 10:43 AM

Changes (40)

				Path	Packages
	M			src/client/blur.cpp
	M			src/client/buffer_p.h
	M			src/client/compositor.cpp
	M			src/client/connection_thread.cpp
	M			src/client/contrast.cpp
	M			src/client/datadevice.cpp
	M			src/client/datadevicemanager.cpp
	M			src/client/dataoffer.cpp
	M			src/client/datasource.cpp
	M			src/client/dpms.cpp
	M			src/client/event_queue.cpp
	M			src/client/fakeinput.cpp
	M			src/client/fullscreen_shell.cpp
	M			src/client/idle.cpp
	M			src/client/keyboard.cpp
	M			src/client/output.cpp
	M			src/client/outputconfiguration.cpp
	M			src/client/outputdevice.cpp
	M			src/client/outputmanagement.cpp
	M			src/client/plasmashell.cpp
	M			src/client/plasmawindowmanagement.cpp
	M			src/client/plasmawindowmodel.cpp
	M			src/client/pointer.cpp
	M			src/client/pointerconstraints.cpp
	M			src/client/pointergestures.cpp
	M			src/client/region.cpp
	M			src/client/registry.cpp
	M			src/client/relativepointer.cpp
	M			src/client/seat.cpp
	M			src/client/server_decoration.cpp
	M			src/client/shadow.cpp
	M			src/client/shell.cpp
	M			src/client/shm_pool.cpp
	M			src/client/slide.cpp
	M			src/client/subcompositor.cpp
	M			src/client/subsurface.cpp
	M			src/client/surface.cpp
	M			src/client/textinput_p.h
	M			src/client/touch.cpp
	M			src/client/xdgshell_p.h