Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
ClosedPublic

Authored by davidedmundson on Aug 14 2017, 10:56 AM.

Details

Summary

Nested classes inherit the visibility of their outer class,
so all the KClass::Private symbols have also been exported
if the ones of KClass were.

See also https://phabricator.kde.org/D7279

Test Plan

Ran nm -DC to list symbols
Only changed visibility of classes defined in .cpp files, so no client code should be affected.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
dfaure accepted this revision.Aug 15 2017, 1:22 PM
This revision is now accepted and ready to land.Aug 15 2017, 1:22 PM
This revision was automatically updated to reflect the committed changes.