Don't close plasmoid when closing a subdialog
ClosedPublic
Actions

Authored by hein on Jan 17 2018, 2:44 PM.

Details

Reviewers

Group Reviewers

Commits

R119:fc155e94457d: Don't close plasmoid when closing a subdialog
R120:cc2038fbd673: Don't close plasmoid when closing a subdialog

Summary

This patch redoes the fencing mechanism around
plasmoid.hideOnWindowDeactivate for window focus
handovers to be more reliable and generic. It's now
always disabled when a dialog is about to be
destroyed, and renabled on focus-in or when exiting
the root list. The dialog code is also fixed not
to close the plasmoid when it knows it's window
deactivation is part of its own destruction.

WindowSystem::monitorWindowFocus is also changed
to work in a single-shot sort of way, removing
the event filter again once it caught an event.

Fixes a refactoring regression from 84f1cb1c1.

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein created this revision.Jan 17 2018, 2:44 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2018, 2:44 PM

hein requested review of this revision.Jan 17 2018, 2:44 PM

This partly fixes the issue. After applying this I can still reproduce by moving the mouse from the list to the gap between the list and the search box.

ngraham edited the summary of this revision. (Show Details)Jan 17 2018, 4:56 PM

In D9945#192419, @cfeck wrote:

This partly fixes the issue. After applying this I can still reproduce by moving the mouse from the list to the gap between the list and the search box.

The gap between the list and the search box is in the top-level dialog, not a subdialog. This is not what this patch is about as per the description.

The issue you mention is a related thing as mentioned in the second paragraph. It will need a seperate patch as it's a seperate issue. Please ignore it in this review.

@ngraham: "BUG:number" is the correct form, please don't add the spaces there :).

Sorry about that. I was going by https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages, which lists them with spaces. between the colon and the number.

Address both bugs in one.

@ngraham: I guess both work but the non-space one is the historical one ... oh well :)

Sorry, please ignore the .desktop noise in review. I'll fix it on push.

mart accepted this revision.Jan 22 2018, 9:55 AM

mart added a subscriber: mart.

mart added inline comments.

kcms/keyboard/kcm_keyboard.desktop
126 ↗	(On Diff #25639)	this shouldn't be in the final commit

This revision is now accepted and ready to land.Jan 22 2018, 9:55 AM

Closed by commit R119:fc155e94457d: Don't close plasmoid when closing a subdialog (authored by hein). · Explain WhyJan 22 2018, 10:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/kicker/package/contents/ui/ItemListDialog.qml (12 lines)
M			applets/kicker/package/contents/ui/ItemListView.qml (11 lines)
M			applets/kicker/package/contents/ui/main.qml (3 lines)
M			applets/kicker/plugin/windowsystem.h (2 lines)
M			applets/kicker/plugin/windowsystem.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25541	b38e955		Jan 17 2018, 2:44 PM	★	★
Diff 2	25639	5551d9b	Address both bugs in one.	Jan 19 2018, 1:04 PM	★	★
Diff 3	25743	c9d7c9d	R119:fc155e94457d5767100bb108e39355094a373424	Jan 22 2018, 10:34 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
df3ff635ce82	8b974b5d81a3	b38e955f83c5	Eike Hein	Don't close plasmoid when closing a subdialog (Show More…)	Jan 17 2018, 2:35 PM
b38e955f83c5	a1dde30d7c69	5551d9be17dd	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Jan 17 2018, 5:45 AM