[UDisks Device] Show loop device with their backing file name and icon
ClosedPublic
Actions

Authored by broulik on Jan 15 2018, 5:55 PM.

Details

Reviewers

davidedmundson
bshah

Group Reviewers

VDG

Commits

Summary

Instead of showing generic "Loop Device" for everything, use the backing file's file name and mime type icon.

Test Plan

Mounted a random iso file, showed up with file name and ISO icon in Dolphin sidebar.
Before

After

(This is also in preparation for getting rid of those useless "Loop Devices" in the first place)

Repository

R245 Solid

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

broulik requested review of this revision.Jan 15 2018, 5:55 PM

apol added inline comments.

src/solid/devices/backends/udisks2/udisksdevice.cpp
614 ↗	(On Diff #25407)	return QStringLiteral("drive-harddisk");

, showed up with file name a

This revision is now accepted and ready to land.Jan 23 2018, 3:24 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/solid/devices/backends/udisks2/udisksdevice.h (1 line)
M			src/solid/devices/backends/udisks2/udisksdevice.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25407			Jan 15 2018, 5:52 PM	★	★
Diff 2	25827	9d7a417	R245:3e9c2791fd3f3ce66b81386510270cb3ab4c0dcb	Jan 23 2018, 4:04 PM	★	★