[effects/blur] Disable texture cache on Wayland
ClosedPublic

Authored by graesslin on Jan 14 2018, 8:02 PM.

Details

Summary

It is known to create problems especially on multi-screen and is not as
important on Wayland as it used to be on X11 thanks to things like
buffer age and in general better rendering.

Test Plan

Opened the config module and verified that the option is disabled

Diff Detail

Repository
R108 KWin
Branch
blur-no-cache-wayland
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Jan 14 2018, 8:02 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 14 2018, 8:02 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Jan 14 2018, 8:02 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 14 2018, 8:02 PM
broulik added inline comments.
effects/blur/blur_config.cpp
42

Shouldn't it hide or at least disable the check box?

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 14 2018, 8:06 PM
graesslin updated this revision to Diff 25343.Jan 14 2018, 8:20 PM

Also disable the cache blur checkbox on Wayland

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 14 2018, 8:20 PM

Also disable the cache blur checkbox on Wayland

ah no, that's a stupid idea. The load call enables it again. I'll hide it.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 14 2018, 8:21 PM
graesslin updated this revision to Diff 25345.Jan 14 2018, 8:23 PM

Hide option instead of disable it

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 14 2018, 8:23 PM

On a general note, UI-wise: if there's no way to ever enable an item it should not be shown anyway.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 14 2018, 8:23 PM
broulik accepted this revision.Jan 15 2018, 9:44 AM
This revision is now accepted and ready to land.Jan 15 2018, 9:44 AM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 15 2018, 9:44 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 15 2018, 4:13 PM

This change will be superseded by: https://phabricator.kde.org/D9848
I just removed the caching blur altogether.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 16 2018, 1:54 AM