Differential D9802

Avoid Dolphin crash
AbandonedPublic
Actions

Authored by michaelh on Jan 10 2018, 7:39 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
Frameworks
Summary

Removed Q_ASSERT

Test Plan

$ dolphin tags:/Genre/Drama/

Diff Detail

Repository
R241 KIO
Branch
nestedtags (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh requested review of this revision.EditedJan 10 2018, 7:39 PM
michaelh created this revision.

Reason:
dolphin crashes when navigating to a nested tag e.g.

tags:/Genre/Drama/
ngraham added a comment.Jan 10 2018, 7:42 PM

Hmm, I can't reproduce the crash with Dolphin and KIO from git master. dolphin tags:/Genre/Drama/ (after created a nested tag Genre/Drama) works fine for me.

akrutzler added a subscriber: akrutzler.Jan 10 2018, 7:44 PM
akrutzler added inline comments.
src/core/kcoredirlister.cpp
1233

Q_ASSERT is just executed in debug builds. It wont crash in release builds.
Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT

michaelh added inline comments.Jan 10 2018, 7:50 PM
src/core/kcoredirlister.cpp
1233

I'm working with kio right now. Is better to just comment it out for the time being?

akrutzler added inline comments.Jan 10 2018, 7:56 PM
src/core/kcoredirlister.cpp
1233

Yes, i would just comment this out :) Once you are done, undo the comment.

michaelh abandoned this revision.Jan 10 2018, 7:56 PM
michaelh marked 3 inline comments as done.Jan 10 2018, 8:03 PM
michaelh added inline comments.
src/core/kcoredirlister.cpp
1233

I'd like to ask for some help here.
Debugging in KDevelop, trying to step through the code:
it's not possible for me. Sometimes the debugger even crashed.

  • I checked for debugging symbols with file libKF5*: OK
  • I checked loading with lsof $(pgrep dolphin): OK

What do I miss?

michaelh marked an inline comment as done.Jan 10 2018, 8:10 PM
akrutzler added inline comments.Jan 10 2018, 10:11 PM
src/core/kcoredirlister.cpp
1233

Sorry i don't use KDevelop, i am using QtCreator and debugging works pretty good there. Maybe give QtCreator a try :)

michaelh marked 2 inline comments as done.Jan 11 2018, 12:20 AM

Revision Contents
Changeset List

PathPackages
Msrc/core/kcoredirlister.cpp (1 line)

Diff 25116

View Options

src/core/kcoredirlister.cpp

Loading...